Skip to content

added initial nightly-builder app - #71

Merged
rvagg merged 3 commits into
masterfrom
nightly-builder
Apr 21, 2015
Merged

rvagg merged 3 commits into
masterfrom
nightly-builder

Conversation

@rvagg

@rvagg rvagg commented Apr 11, 2015

Copy link
Copy Markdown
Member

Probably R=@Fishrock123 but input welcome from others.

This app is to be used via cron to trigger nightly builds for both nightly and next-nightly. It finds the latest build and gets the commit sha from it, then it compares that commit sha of the appropriate git branch (v1.x for nightly and next for next-nightly). If they don't match then it triggers a build on Jenkins using all the appropriate parameters for the iojs+release+nightly including an authorization token that's in the job configuration.

Used it just now to build https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/139/

@rvagg

rvagg commented Apr 11, 2015

Copy link
Copy Markdown
Member Author

probably needs readme ..

@cjihrig

cjihrig commented Apr 11, 2015

Copy link
Copy Markdown
Contributor

Thoughts on using the same coding style as node core?

@rvagg

rvagg commented Apr 11, 2015

Copy link
Copy Markdown
Member Author

running on iojs-www in /etc/crontab:

0 18    * * *   dist    node /home/dist/nightly-builder/ --type nightly --token redacted
0 19    * * *   dist    node /home/dist/nightly-builder/ --type next-nightly --token redacted

this server is running as UTC-4 (unfortunately)

@rvagg

rvagg commented Apr 11, 2015

Copy link
Copy Markdown
Member Author

Thoughts on using the same coding style as node core?

1cda5be0f1bc1ac709847305a1565c72__tumblr_inline_n0510cwkrd1r3yh7o

@cjihrig

cjihrig commented Apr 11, 2015

Copy link
Copy Markdown
Contributor

Sorry 😨

This comment was marked as off-topic.

@Fishrock123

Copy link
Copy Markdown
Contributor

Seems fine. Some style meh, but no big deal I suppose. Mostly just leftover nits.

@rvagg
rvagg force-pushed the nightly-builder branch from 9b1c6d0 to 50c9efd Compare April 16, 2015 06:57
@rvagg
rvagg merged commit 310df1f into master Apr 21, 2015
@rvagg
rvagg deleted the nightly-builder branch April 21, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants