Skip to content

fix(listener): In Node.js v24, some response bodies are not read to the end until the next task queue. - #265

Merged
yusukebe merged 1 commit into
honojs:mainfrom
usualoma:fix-wait-next-task-node24
Jul 31, 2025
Merged

yusukebe merged 1 commit into
honojs:mainfrom
usualoma:fix-wait-next-task-node24

Conversation

@usualoma

@usualoma usualoma commented Jul 29, 2025 •

Copy link
Copy Markdown
Member

Fixes #264

I considered making the following additional commit, but since it would change the behavior a bit and I am concerned about the performance impact (and, in fact, the need to deal with more case-sensitive parts), I would like to complete the fix with only the first commit and not add anything in particular.

usualoma/node-server@fix-wait-next-task-node24...usualoma:node-server:fix-wait-next-task-node24-2

Comment thread src/listener.ts Resolved
@usualoma usualoma changed the title fix(listener): In Node.js v24, some response bodies are not read to the end until the next task queue. fix(listener): Improve handling of response body Jul 30, 2025
@usualoma usualoma changed the title fix(listener): Improve handling of response body fix(listener): In Node.js v24, some response bodies are not read to the end until the next task queue. Jul 30, 2025
@usualoma
usualoma force-pushed the fix-wait-next-task-node24 branch from 16d1029 to 98f2792 Compare July 30, 2025 23:32
@usualoma
usualoma marked this pull request as ready for review July 30, 2025 23:45
@usualoma

Copy link
Copy Markdown
Member Author

Hi @yusukebe.

The content is still in the first version. Please review with this.

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe

Copy link
Copy Markdown
Member

@usualoma

Looks good to me. I'll merge and release a new version. Thank you!

but since it would change the behavior a bit and I am concerned about the performance impact (and, in fact, the need to deal with more case-sensitive parts), I would like to complete the fix with only the first commit and not add anything in particular.

Agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server.test.ts fails on Node.js v24

2 participants