Repository navigation
fix(release): stop release e2e flaking on the GitHub username lookup - #37544
Merged
Merged
Conversation
The zero-config test committed as test@test.com, so its changelog snapshot needed a live ungh.cc lookup. ungh fronts GitHub's rate-limited user search; when it failed the Thank You line lost its @username. Commit with a noreply author so the username resolves offline.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit b0ed578
☁️ Nx Cloud last updated this comment at |
Swap test@test.com for test@users.noreply.github.com in the agent env, the e2e matrix global config and the e2e git config lines. nx release now resolves the author's GitHub username locally in every release e2e with a GitHub remote, so no test depends on ungh.cc. This makes the --author override from the previous commit redundant, so it is removed.
AgentEnder
approved these changes
Oct 21, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
e2e/release/src/release.test.ts› "should version and publish multiple related npm packages with zero config" flakes often. Two inline snapshots fail because the changelog's Thank You line is- Testinstead of- Test @{COMMIT_AUTHOR}.CI commits as
test@test.com. Because the test adds agithub.comremote,nx release changelogmaps authors to GitHub usernames, which for that email means a livehttps://ungh.cc/users/find/test@test.comlookup. ungh sits in front of GitHub's rate-limited user search. When it fails, theghCLI fallback is not authenticated on agents either, so the username is dropped. The other release e2e tests with a GitHub remote make the same network call; they just don't snapshot the result.Expected Behavior
e2e commits use
test@users.noreply.github.com, set in the Nx Agents env (.nx/workflows/agents.yaml), the e2e matrix global git config, and each e2egit config user.emailline.applyUsernameToAuthorsparses noreply emails locally before any network call, so the username resolves offline on every run. The snapshots are unchanged (Test @testis still normalized toTest @{COMMIT_AUTHOR}).The first commit fixed only
release.test.tswith a per-commit--author; the second commit replaces that with the shared setup change.Related Issue(s)
N/A
View Polygraph session ↗