Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thanks for this. One thing before we can take it: on Windows and Linux, AltGr is reported as Ctrl+Alt, and on some keyboard layouts (Czech and Hungarian, for example) Could you skip the early return when AltGr is held, in both if ((event.metaKey || event.ctrlKey || event.altKey) && !event.getModifierState("AltGraph")) return;Please also merge main (the branch is a long way behind) and mark the PR ready for review. Once that's in, we'll run the Greptile review, and it needs 5/5 plus green CI to merge. |
|
Good catch, thanks. Both handlers now skip the early return when |
Fixes #2596.
Problem
The share-page player's key handler matched on
event.keyalone and calledpreventDefault(). So ⌘⇧M, Chrome's profile-menu shortcut, muted the video and Chrome never saw it. Other combinations such as ⌘K and ⌘F, and Ctrl/Alt variants, were swallowed the same way.Fix
onKeyDownandonKeyUpreturn early when Meta, Ctrl or Alt is held, unless AltGr is held. Windows and Linux report AltGr as Ctrl+Alt, and some layouts (Czech, Hungarian) type<and>with it, so the playback-speed shortcuts keep working there. Shift still reaches the handler, because Shift+Arrow is used to seek audio.Testing
</>still change playback speed

Confidence Score: 5/5
The PR appears safe to merge.Summary
The share player now lets Cmd, Ctrl and Alt shortcuts pass through without triggering player actions.
Reviews (1) · Last reviewed commit: "fix(web): keep AltGr shortcuts working i..." · Reviewed by Greptile