Repository navigation
fix(desktop-gpui): place windows correctly on displays above or below the primary - #2811
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Conversation
…ow the primary GPUI's macOS visible_bounds is relative to its own display, but the work area conversion treated its y as AppKit-global. On a display stacked above or below the primary one the recording controls were clamped off-screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@flyingwebie is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 21, 2026
Member
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #2774 as requested in review.
GPUI's macOS
visible_boundsis relative to its own display, butglobal_macos_work_areainapp_windows.rstreated its y as AppKit-global. On a display stacked above or below the primary one, the recording controls were clamped off-screen. The work area now just carries the display's global origin across.Testing
cargo test --bin cap-gpui macos_work_areainapps/desktop-gpui: passes, with a new case for a display above and to the right of the primary (1691, -1080).🤖 Generated with Claude Code
The PR appears safe to merge; no actionable issues were found.Summary
Fixes macOS window placement by adding the display’s global origin to its local work area.
Reviews (1) · Last reviewed commit: "🐛 fix(desktop-gpui): place windows corr..." · Reviewed by Greptile