Skip to content

Fix/dynamic aria icon classes - #709

Open
dharamdan01 wants to merge 5 commits into
CodeSeven:masterfrom
dharamdan01:fix/dynamic-aria-icon-classes
Open

dharamdan01 wants to merge 5 commits into
CodeSeven:masterfrom
dharamdan01:fix/dynamic-aria-icon-classes

Conversation

@dharamdan01

Copy link
Copy Markdown

📝 Description

Closes #685

This PR improves ARIA toast handling by using the dynamic toast type to determine the appropriate polite or assertive state instead of relying on fixed icon class values.

The updated behavior also applies the corresponding toast class and container layout, making the notification states more consistent and distinguishable.

🛠️ How Was This Implemented?

  • Generate the icon class dynamically from the toast type.
  • Apply polite or assertive based on the dynamic toast type.
  • Set the matching aria-live attribute.
  • Update the container layout for assertive notifications.
  • Added styling to visually distinguish both states.

Visuals

assertive polite

🧪 Testing Instructions

  1. Display success/info and other toast types.
  2. Verify the dynamic icon class and corresponding aria-live value.
  3. Verify the correct polite or assertive class is applied.
  4. Verify assertive notifications use the updated full-width layout.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setAria

1 participant