Repository navigation
Emit buffered adjacent groups before upstream failure - #10240
Merged
tim-smart merged 3 commits intoNov 1, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 13aac2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Stream.groupAdjacentBydrops its last group when upstream fails. Grouping[1, 1, 2, 2]followed by a failure emits only the group for1before the error.Keep the terminal cause, emit the buffered group once, then propagate that cause on the next pull. This follows the buffering behavior of
rechunkandslidingSize.The regression covers a group spanning input chunks. Verified with the core package tests, Stream type tests, root typecheck, lint components and core build.
Related
Follows #9916, which left
groupAdjacentByfor a follow-up.Closes EFF-3241