Skip to content

docs(contributing): define limits for illustrative drafts before work acceptance - #4999

Closed
TechWizard9999 wants to merge 2 commits into
NVIDIA:mainfrom
TechWizard9999:docs/4952-illustrative-drafts/TechWizard9999
Closed

TechWizard9999 wants to merge 2 commits into
NVIDIA:mainfrom
TechWizard9999:docs/4952-illustrative-drafts/TechWizard9999

Conversation

@TechWizard9999

Copy link
Copy Markdown

Summary

Define limits, required context, and review expectations for illustrative drafts opened before work acceptance, and exempt draft pull requests from the issue acceptance check while in draft.

Related Issue

Closes #4952

Changes

  • Add the ### Illustrative Drafts for Unaccepted Work subsection to CONTRIBUTING.md defining purpose, scope limits, required context, review expectations, and positive/negative examples.
  • Update CONTRIBUTING.md line 32 to clarify that illustrative drafts never bypass the first-time contributor vouch requirement.
  • Reconcile CONTRIBUTING.md line 449, AGENTS.md, and contributor skills (create-github-pr, review-github-pr, PULL_REQUEST_TEMPLATE.md) to permit illustrative drafts while in draft state, retaining the acceptance check when marked ready for review.
  • Exempt draft PRs from tasks/scripts/check_issue_acceptance.cjs and add unit test coverage in tasks/scripts/check_issue_acceptance.test.cjs.
  • Add ready_for_review to .github/workflows/pr-issue-acceptance.yml pull_request_target trigger types.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated in tasks/scripts/check_issue_acceptance.test.cjs (22/22 tests passing)
  • Markdown linting validated via markdownlint-cli2 (0 errors across 163 files)
  • YAML syntax validated for .github/workflows/pr-issue-acceptance.yml

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

… acceptance

Signed-off-by: TechWizard9999 <119874392+TechWizard9999@users.noreply.github.com>
Signed-off-by: TechWizard9999 <119874392+TechWizard9999@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TechWizard9999
TechWizard9999 requested review from a team and derekwaynecarr as code owners October 28, 2026 13:01
@github-actions

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @TechWizard9999.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot closed this Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@TechWizard9999

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

@purp

purp commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your look at this. We've found that too much documentation floods agent context, making work less efficient and sometimes prone to missing instructions. This is one of the cases I'd leave as is; the benefit is too low for the amount of docs.

@TechWizard9999

Copy link
Copy Markdown
Author

Hi @purp , Actually I am intrested in contributing to this repo do we have some easy - medium level issues if possibe can you point or assign to me , I would like to work on it
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(contributing): define limits for illustrative drafts before work acceptance

2 participants