Repository navigation
Preserve filesystem subclass types in context managers - #608
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
FS.__enter__returns the same instance but annotates the result asFS, widening concrete subclasses inwithblocks. Bind its return to the existing_Fself type variable, so aTempFS,OSFS, or custom subclass keeps its concrete type. Related to the type-inference aspect of #580.The mypy regression reports three errors on the base and passes with the change using the repository's pinned mypy 0.800 on Windows/Python 3.9.25. It skips when mypy is unavailable. Related base/memory/temp filesystem tests have 280 passes, 4 skips and 2 symlink-permission failures; the same two WinError 1314 failures reproduce on unchanged upstream. Pinned Black, Flake8 with configured plugins and the changed-file type check pass. The full 57-file type check has the same five diagnostics before and after. Other runtimes, the complete project suite and the full platform matrix were not run.