Skip to content

move grouped results into helpers out of [ - #7943

Open
ben-schwen wants to merge 2 commits into
brk/a7_SDenvfrom
brk/a8_grouped_results
Open

ben-schwen wants to merge 2 commits into
brk/a7_SDenvfrom
brk/a8_grouped_results

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

Towards #852

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (brk/a7_SDenv@06cf638). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             brk/a7_SDenv    #7943   +/-   ##
===============================================
  Coverage                ?   99.09%           
===============================================
  Files                   ?       88           
  Lines                   ?    17440           
  Branches                ?        0           
===============================================
  Hits                    ?    17282           
  Misses                  ?      158           
  Partials                ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from e8f6638 to 2155098 Compare October 24, 2026 23:15
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
  • HEAD=brk/a8_grouped_results much slower for melt(measure()) improved in #7917
  • HEAD=brk/a8_grouped_results much slower for transform improved in #5493
  • HEAD=brk/a8_grouped_results faster P<0.001 for memrecycle regression fixed in #5463
  • HEAD=brk/a8_grouped_results faster P<0.001 for DT[by] max regression fixed in #7480

(Plot image upload to picrd.com failed; download the artifact below to view plots)

Generated via commit f2d1816

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 46 seconds
Installing different package versions 46 seconds
Running and plotting the test cases 5 minutes and 53 seconds

@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from 2155098 to 6f04972 Compare October 26, 2026 15:13
Comment thread R/data.table.R Resolved
Comment thread R/data.table.R Resolved
Comment thread R/data.table.R Resolved
Comment thread R/data.table.R Resolved
Comment thread R/data.table.R Resolved
Comment thread R/data.table.R Resolved
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch 3 times, most recently from 8027cd0 to e2955bf Compare November 1, 2026 22:20
@ben-schwen
ben-schwen removed this pull request from stack #7933 November 3, 2026 09:15
@ben-schwen
ben-schwen added this pull request to stack #7953 November 3, 2026 09:16
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from e2955bf to 8793722 Compare November 3, 2026 09:18
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from 8793722 to 65c884d Compare November 3, 2026 09:51
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch 3 times, most recently from 78c0705 to 97c83da Compare November 3, 2026 10:31
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from 97c83da to b874fcd Compare November 3, 2026 17:25
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from b874fcd to dbafb25 Compare November 3, 2026 17:46
ben-schwen and others added 2 commits November 3, 2026 18:55
using early return more often

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
@ben-schwen
ben-schwen force-pushed the brk/a8_grouped_results branch from dbafb25 to f2d1816 Compare November 3, 2026 18:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants