Skip to content

Creating sprites without a texture crashes python #145

Open

Description

@tgrajewski

This line crashes python:

sprite = sf.Sprite(None)

Would be great if at least an exception could be thrown here. And even better would be if a non-renderable sprite would be created with a possibility of setting a texture later in code.

Activity

  1. intjelic commented on Mar 3, 2017

    @intjelic
    Member

    You're right andd actually I'm aware of that, I'll look into that soon!

  2. Necklaces commented on Jun 10, 2017

    @Necklaces

    To me it looks like it's cythons fault somehow, I mean this works and correctly raises an error:

    >>> from sfml import sf
    >>> sf.Sprite(False)
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    TypeError: Argument 'texture' has incorrect type (expected sfml.graphics.Texture, got bool)
    

    But None just straight out segfaults it..

    >>> sf.Sprite(None)
    Segmentation fault (core dumped)
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions