Repository navigation
Share dev preview helpers between app dev and future commands - #9026
Draft
nickwesselman wants to merge 1 commit into
Draft
nickwesselman wants to merge 1 commit into
nickwesselman wants to merge 1 commit into
Conversation
1 of 4 tasks
Extract URL rewriting, bundle upload, and admin preview link helpers; add optional cancellation to bundle upload and dev session creation; let store selection skip user-access provisioning. No behavior change for existing commands. Co-authored-by: Qlaw <noreply@qlaw.quick.shopify.io>
nickwesselman
force-pushed
the
nickw/dev-preview-helpers
branch
from
October 28, 2026 14:44
2ef12cf to
f694035
Compare
nickwesselman
changed the base branch from
main
to
nickw/fix-app-dev-store-token-access
October 28, 2026 14:44
1 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middle of a stack: on PR 9015 (automation token scopes) and under PR 9016 (
app dev push).WHY are these changes introduced?
app devholds a few pieces of logic that a finite "push a dev preview and exit" command also needs: rewriting app URLs for a dev origin, uploading a compressed bundle to a signed URL, and building the admin preview link. Extracting them first keeps the command PR limited to new files.WHAT is this pull request doing?
Refactor only;
app dev,deploy, and the app loader behave exactly as before.generateApplicationURLsForApp()replaces three copies of the same callback-path/app-proxy lookup indev.ts,dev-push-to-be, andloader.ts.uploadDevBundle()anddevBundlePath()(newdev/dev-bundle.ts) replace the signed-URL-then-upload sequence indev-session.ts.buildAppURLForAdmin()gains a{devConsole: false}option.uploadToGCS()anddevSessionCreate()accept an optionalAbortSignal; without one, requests are unchanged.storeContext()gainsensureUserAccess(defaulttrue) so remote-only commands can skip user-access provisioning;blockIfMigrationIncomplete()only requires the fields it reads.No changeset: nothing user-facing changes.
How to manually test your changes?
pnpm shopify app devagainst a dev store with--url-style tunnelling as usual; the preview and OAuth callback URLs should be identical to before.app devis running; the preview should update as before (this exercises the extracted upload helper).pnpm shopify app deploy; bundle upload is unchanged.Checklist
PR authored by Qlaw