Skip to content

Documentation for 'import/no-extraneous-dependencies' is missing #2727

Open

Description

@cseas

The rule is set to error in the config:
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js#L71

But there's no mention of it in the guide:
https://github.com/airbnb/javascript/blob/master/README.md

This rule should be mentioned under the Modules section.

Activity

  1. ljharb commented on Feb 14, 2023

    @ljharb
    Collaborator

    Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

  2. MohitBansal321 commented on Feb 22, 2023

    @MohitBansal321

    Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-)

    I didn't find link related to this rule on eslint

  3. ljharb commented on Feb 22, 2023

    @ljharb
    Collaborator

    It's part of eslint-plugin-import.

  4. MohitBansal321 commented on Feb 23, 2023

    @MohitBansal321

    It's part of eslint-plugin-import.

    Link (this one?)
    on which part of the modules should be added?

  5. ljharb commented on Feb 23, 2023

    @ljharb
    Collaborator

    Yep, that's the rule.

    I guess as a new section at the end of Modules?

  6. meddy672 commented on Mar 23, 2023

    @meddy672

    I have a PR up. Please take a look.

  7. Vivek-04022001 commented on Mar 24, 2023

    @Vivek-04022001
  8. ljharb commented on Mar 24, 2023

    @ljharb
  9. utkarsh-shrivastav77 commented on May 15, 2023

    @utkarsh-shrivastav77
  10. ljharb commented on May 15, 2023

    @ljharb
  11. cyberwarrior-20 commented on Jul 30, 2023

    @cyberwarrior-20

    hi @cseas i can solve this issue please assign me

  12. angeloreale commented on Apr 18, 2024

    @angeloreale

    My .50 cents? Why is it something should be made a code style pattern if it can directly affect bundle sizes for ES modules?

  13. ljharb commented on Apr 18, 2024

    @ljharb
    Collaborator

    Everything can affect that, and that’s just not a rubric anyone should be applying to how your code is written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions