Repository navigation
docs(material/tabs): clarify when background and foreground tokens apply - #33988
Open
lxminarayn wants to merge 1 commit into
Open
lxminarayn wants to merge 1 commit into
lxminarayn wants to merge 1 commit into
Conversation
crisbeto
reviewed
Oct 21, 2026
crisbeto
left a comment
Member
There was a problem hiding this comment.
We intentionally didn't support this. It's a legacy feature that is only in M2, not M3.
Author
|
Thanks for clarifying & quick review! That makes sense given backgroundColor is M2-only and deprecated. The confusion in #30186 seems to come from tabs-overrides accepting background-color and foreground-color in M3 and the styling docs listing them, even though they have no effect there. Would you be open to a small change that documents these two tokens as only applying with the M2 backgroundColor input, or excludes them from the M3 overrides? If not, I'm happy to close this. |
Member
|
Sure, we can change it to a docs PR. |
Notes that the `background-color` and `foreground-color` tokens only take effect when the `backgroundColor` input is set, which is supported in M2 themes only, and points to the tokens that customize the label and indicator colors in M3 themes. Fixes angular#30186.
lxminarayn
force-pushed
the
fix/tabs-overrides-background-foreground-30186
branch
from
October 22, 2026 04:22
1caf3ef to
4bef01b
Compare
Author
|
@crisbeto , I've replaced the change with a docs update to the tabs overview. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that the
background-colorandforeground-colortokens oftabs-overridesonlytake effect together with the
backgroundColorinput, which is supported in M2 themes only,and points to the tokens that customize the label and indicator colors in M3 themes.
Fixes #30186