Repository navigation
MsSql: Keep the comma separator when displaying DECLARE lists - #2671
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
==========================================
+ Coverage 81.25% 81.26% +0.01%
==========================================
Files 42 42
Lines 33910 33920 +10
Branches 33910 33920 +10
==========================================
+ Hits 27553 27566 +13
+ Misses 2792 2790 -2
+ Partials 3565 3564 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MsSql one
DECLAREkeyword takes a comma-separated list of declarations,DECLARE @a INT, @b INT(https://learn.microsoft.com/en-us/sql/t-sql/language-elements/declare-local-variable-transact-sql). The parser collected the list into oneStatement::Declare, but the display joined it with;, so the statement was printed back asDECLARE @a INT; @b INT, which T-SQL reads as a different statement.Statement::Declaregains aseparator: DeclareSeparatorfield. The MsSql parser recordsComma, and the Snowflake, BigQuery and cursor forms recordSemicolon, matching Snowflake Scripting'sDECLAREsection where each declaration ends with;(https://docs.snowflake.com/en/sql-reference/snowflake-scripting/declare).