Skip to content

update on conflict with condition - #735

Merged
alamb merged 1 commit into
apache:mainfrom
zidaye:feature/on_conflict_with_condition
Nov 30, 2022
Merged

alamb merged 1 commit into
apache:mainfrom
zidaye:feature/on_conflict_with_condition

Conversation

@zidaye

@zidaye zidaye commented Nov 29, 2022 •

Copy link
Copy Markdown
Contributor

@baoyachi

Copy link
Copy Markdown

LGTM

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zidaye

Comment thread src/ast/mod.rs
/// Column assignments
pub assignments: Vec<Assignment>,
/// WHERE
pub selection: Option<Expr>,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is to call this where to match the SQL more closely -- I will make this change in a follow on PR

@alamb alamb Nov 30, 2022 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now I see the name selection is consistent with the rest of this crate (e.g. https://github.com/sqlparser-rs/sqlparser-rs/blob/faf75b71613431e66ec22c82e3c9ad6157474458/src/ast/mod.rs#L1139)

I will not make any other changes

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3573700071

  • 46 of 48 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.378%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 8 10 80.0%
Totals Coverage Status
Change from base Build 3568725328: 0.02%
Covered Lines: 11921
Relevant Lines: 13801

💛 - Coveralls

@alamb
alamb merged commit 042effd into apache:main Nov 30, 2022
@alamb

alamb commented Nov 30, 2022 •

Copy link
Copy Markdown
Contributor

Thanks again @zidaye and @baoyachi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants