Repository navigation
Conversation
Member
|
Hi @lazerg, Thanks for bringing this to our attention and thank you for the fix. We'll wait until after today's release to merge this, but the changes look good to me. |
stobrien89
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #3370
Description of changes:
The rejection callback in AssumeRoleCredentialProvider was typed to RuntimeException, so when the STS call failed with any other exception, PHP threw a TypeError from the callback and the original exception was lost. The callback now accepts Throwable and wraps every failure in the same CredentialsException, with the original kept as the previous exception. I wrapped the other failures instead of rethrowing them unchanged, because the CredentialProvider docblock says providers reject with a CredentialsException, and EcsCredentialProvider already wraps any rejection reason the same way.
Generated by AI tools, and reviewed by @lazerg.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.