You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The branch targets main and no longer merges onto development (the relation options moved around with #538 and later PRs). Could you rebase onto current development and retarget the PR? The two relation options are unset by default, so once it applies cleanly and the suite passes it can go in.
@tsia since this was opened, development gained cluster_scope_type_relation and cluster_scope_id_relation (#475), which let a cluster be scoped to a region (Cluster_X = dcim.region plus the region's NetBox id) instead of a site, and that is what 1.9 ships with. It covers the use case here with the id rather than the name. Is that enough for you? If a name-based cluster_region_relation is still worth it, the branch needs a rebase on development; otherwise I'll close this in a couple of weeks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the option to map vmware clusters and hosts to a region instead of a site