Skip to content

fix(terminal): native terminal window flags - #299

Closed
mbfoss wants to merge 4 commits into
coder:mainfrom
mbfoss:main
Closed

mbfoss wants to merge 4 commits into
coder:mainfrom
mbfoss:main

Conversation

@mbfoss

@mbfoss mbfoss commented Jul 3, 2026

Copy link
Copy Markdown

Fix for 2 issues:

  • Native terminal window is not protected against resize (for example after C-W + = )
  • Native terminal window is not protected against buffer change

mbfoss added 4 commits July 3, 2026 23:32
Fix for 2 issues:
- Native terminal window is not protected against resize (for example after C-W + = )
- Native terminal window is not protected against buffer change
This reverts commit 11ea6e7.
@mbfoss mbfoss closed this Oct 25, 2026
MichaelPachec0 added a commit to MichaelPachec0/claudecode.nvim that referenced this pull request Oct 28, 2026
coder#299

Adjusted on merge:
- Window options moved into an apply_terminal_window_options() helper used by
  both open_terminal and show_hidden_terminal.
- 'winfixbuf' is only set on Neovim >= 0.10 (the option does not exist before
  that and setting it raises 'Unknown option'; the plugin supports >= 0.8).
- Replaced the buffer-local spelloptions=noplainbuffer (not valid on 0.8) with
  window-local spell=false, which states the intent directly.
- Conflict in terminal/native.lua with PRs coder#168/coder#202 resolved by keeping their
  buflisted/filetype buffer options.
- Added vim.wo stubs to the native toggle and command_args specs, plus tests
  that the window is pinned on open and that winfixbuf is skipped on < 0.10.
MichaelPachec0 added a commit to MichaelPachec0/claudecode.nvim that referenced this pull request Oct 28, 2026
PR coder#299 made the native terminal window winfixwidth so <C-w>= keeps its
size, and PR coder#312 added top/bottom split_side. Together a bottom terminal got
winfixwidth, which does nothing for a horizontal split, so <C-w>= still
equalised its height. Pin winfixheight for top/bottom and winfixwidth for
left/right. Explicit resizes (e.g. the diff-time terminal resize) are
unaffected, since winfix* only guards automatic resizing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant