Skip to content

docs(creds): document GCP Secret Manager - #630

Open
sammirza-mo wants to merge 1 commit into
concourse:masterfrom
sammirza-mo:gcp-secretmanager-docs
Open

sammirza-mo wants to merge 1 commit into
concourse:masterfrom
sammirza-mo:gcp-secretmanager-docs

Conversation

@sammirza-mo

Copy link
Copy Markdown

Changes proposed by this PR

Documents the gcpsecretmanager credential manager added in concourse/concourse#9696.

  • New page operation/creds/gcp-secretmanager.md
  • gcpsecretmanager var_source schema in vars.md

Secret Manager IDs can't contain /, unlike the paths used by other managers. The page covers how lookup paths map to secret IDs, which names can't be mapped, and the template rules that are checked at startup. I've tried to make it clear how the templates will map to real secrets through the use a simple example.

Notes to reviewer

Licensing

This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project’s license.

Add a page for the gcpsecretmanager credential manager from
concourse/concourse#9696, and its var_source schema in vars.md.

Secret Manager IDs cannot contain slashes, so the page explains how
lookup paths become secret IDs, and which var, team and pipeline
names cannot be mapped. It also covers the IAM grant, because a
denied lookup fails the build instead of falling through.

Signed-off-by: Sam Mirza <sam.mirza@mechanical-orchard.com>

@taylorsilva taylorsilva left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for being thorough and including detailed examples

I am going to hold off merging this until we're closer to the next release.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants