Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Host copy invites invalid MCP URLs
- Nothing in the plugin trims a pasted URL down to its hostname before
${DATABRICKS_HOST}goes intomcp.json, so I changed theDATABRICKS_HOSTtitle, description and placeholder back to asking for a bare hostname without https://, path or port, matching the README.
- Nothing in the plugin trims a pasted URL down to its hostname before
Or push these changes by commenting:
@cursor push a8fc3c3710
Preview (a8fc3c3710)
diff --git a/third_party/databricks-genie-one/.cursor-plugin/plugin.json b/third_party/databricks-genie-one/.cursor-plugin/plugin.json
--- a/third_party/databricks-genie-one/.cursor-plugin/plugin.json
+++ b/third_party/databricks-genie-one/.cursor-plugin/plugin.json
@@ -41,9 +41,9 @@
"properties": {
"DATABRICKS_HOST": {
"type": "string",
- "title": "Workspace URL",
- "description": "Your workspace URL or Genie MCP URL. Only the hostname is kept.",
- "placeholder": "https://dbc-a1b2c3d4-e5f6.cloud.databricks.com"
+ "title": "Workspace hostname",
+ "description": "Bare workspace hostname. Leave out https://, any path, and any port.",
+ "placeholder": "dbc-a1b2c3d4-e5f6.cloud.databricks.com"
},
"CLIENT_ID": {
"type": "string",You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 8918f14. Configure here.
| "description": "For example, dbc-a1b2c3d4-e5f6.cloud.databricks.com" | ||
| "title": "Workspace URL", | ||
| "description": "Your workspace URL or Genie MCP URL. Only the hostname is kept.", | ||
| "placeholder": "https://dbc-a1b2c3d4-e5f6.cloud.databricks.com" |
There was a problem hiding this comment.
Host copy invites invalid MCP URLs
High Severity · Logic Bug
The setup form now asks for a workspace or Genie MCP URL and shows an https:// example, but DATABRICKS_HOST is still interpolated as a bare hostname in mcp.json. Pasting a URL produces an invalid MCP endpoint, and nothing in this plugin keeps only the hostname.
Reviewed by Cursor Bugbot for commit 8918f14. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update Databricks Genie One setup form copy
The setup form asks for a bare "Workspace hostname" and gives no hints for the client ID or secret fields.
Changes
Note
Low Risk
Copy-only changes to plugin variable metadata; no runtime or auth logic is modified.
Overview
Updates the Databricks Genie One plugin setup schema so users get clearer guidance when connecting OAuth.
The host field is renamed from Workspace hostname to Workspace URL, with copy noting that a full workspace or Genie MCP URL is fine because only the hostname is kept. Placeholders were added for host (example
https://…), client ID (paste from OAuth app), and client secret (leave blank for a public client).Reviewed by Cursor Bugbot for commit 8918f14. Bugbot is set up for automated code reviews on this repo. Configure here.