Repository navigation
fix(v10/core): Use trace_metric data category for metrics rate limits and client reports - #25612
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Oct 21, 2026
Lms24
marked this pull request as ready for review
October 21, 2026 16:49
Lms24
enabled auto-merge (squash)
October 21, 2026 16:49
…ts and client reports Backport of: #25606
Lms24
force-pushed
the
backport/v10-trace-metric-data-category
branch
from
October 27, 2026 12:32
74be39f to
6f27011
Compare
49 of 54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25606
Differences to the original PR
packages/core/src/metrics/internal.tsandpackages/core/test/lib/metrics/internal.test.ts: no change. On v10,_INTERNAL_captureMetricdoes not record client reports whenbeforeSendMetricdrops a metric (and has nocallback_errorhandling), so there is nometriccategory to rename there.packages/core/test/lib/transports/base.test.ts: the newtrace_metricrate limit test expectsrecordDroppedEvent('ratelimit_backoff', 'trace_metric')without a count, because the v10 transport does not passitem_counttorecordDroppedEvent. Also added theEnvelopetype import, which the v10 test file did not have. The 413 container item test from the original PR does not exist on v10, so it was not touched.