Repository navigation
test(e2e): Pin @mastra/deployer in node-mastra to match @mastra/core - #25824
Merged
Merged
Conversation
The mastra CLI depends on @mastra/deployer@^1.65.0, so installs picked up deployer/server 1.80.0, which import a @mastra/core export the pinned 1.74 does not have and fail at startup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 4aa30a1 (PR test merge using develop at c5c2a3a) Against: c5c2a3a (develop) · base run #63956 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 2 successful. See the run. |
mydea
marked this pull request as ready for review
October 28, 2026 14:24
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 28, 2026 14:24
nicohrubec
approved these changes
Oct 28, 2026
msonnb
approved these changes
Oct 28, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The pinned
node-mastraapp has failed on startup since Mastra's release today (The requested module '@mastra/core/error' does not provide an export named 'toPersistedErrorIdentity'). ThemastraCLI depends on@mastra/deployer@^1.65.0, so fresh installs pull deployer/server 1.80.0. Their code needs@mastra/core1.80, but their declared peer range is loose (>=1.58 <2), so nothing stops them being paired with our pinned core 1.74. Pinning@mastra/deployerto the same~1.74.0as core keeps the set in lockstep: pnpm reuses it for the CLI, and deployer 1.74 pins server 1.74. I used a direct dependency rather than a pnpm override so thatnode-mastra (latest)can still bump it withpnpm add ...@latest.How to review: One
package.json. I checked locally with pnpm 12: core/deployer/server resolve to 1.74.0, and the app builds, starts and serves/api/agents. Without the pin, deployer/server resolve to 1.80.0.The node-mastra e2e test app now passes again.
🤖 Generated with Claude Code