Repository navigation
test(remix): Cover prefetched navigations in the Remix 3 E2E app - #25829
Merged
Merged
Conversation
Remix 3.1 adds data-rmx-prefetch. Bump the app to 3.1.0 and check that navigation spans to prefetched links are still named after the route. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 9f3c783 (PR test merge using develop at e17a480) Against: e17a480 (develop) · base run #63967 ✅ Baseline matches: this diff contains only this PR's changes.
|
chargome
marked this pull request as ready for review
October 28, 2026 15:02
chargome
requested review from
a team,
andreiborza,
logaretm,
msonnb,
mydea and
nicohrubec
and removed request for
a team,
andreiborza,
logaretm,
msonnb and
mydea
October 28, 2026 15:02
chargome
enabled auto-merge (squash)
October 28, 2026 15:03
andreiborza
approved these changes
Oct 28, 2026
msonnb
approved these changes
Oct 28, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Remix 3.1 adds link prefetching, so this checks that navigation spans to prefetched links still get the route name. The app moves to 3.1.0 because the prefetch attribute does nothing on 3.0.0.