Repository navigation
fix(replay): Skip buffered replays for captureMessage stacks from the attachStacktrace default - #25846
Merged
Conversation
… attachStacktrace default Defaulting attachStacktrace to true gave captureMessage events a synthetic exception, which made them flush buffered replays. Core now flags message events whose stack only exists because of the default, and Replay skips them in buffer sampling. Users who explicitly set attachStacktrace: true keep the v10 behavior.
Member
Author
|
bugbot run |
Lms24
approved these changes
Oct 28, 2026
Contributor
size-limit report 📦Compared: 8c8afe0 (PR test merge using develop at a33cba8) Against: a33cba8 (develop) · base run #64006 ✅ Baseline matches: this diff contains only this PR's changes.
|
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cb1f074. Configure here.
logaretm
marked this pull request as ready for review
October 28, 2026 17:00
logaretm
requested review from
andreiborza,
chargome,
msonnb and
mydea
and removed request for
a team
October 28, 2026 17:00
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 66 successful. See the run.
Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaulting
attachStacktraceto true gavecaptureMessageevents a synthetic exception so they started flushing buffered replays, fixed by flagging those events in core and skipping them in Replay's buffer sampling.I think a decision to be made later to get rid of this later for when both APIs merge is: should message level captures trigger a replay or not.