[feritcemkahraman]

Disconnecting a <text-expander> closes its menu, clears combobox ARIA state and ignores pending provider results. Cleanup also supports synchronous event handlers that remove or reconnect the element.

Detach old input handlers before deactivation, clear menu/combobox references before notifying listeners, and stop activation when its state or menu was destroyed. Delete the old element state before cleanup so reconnection can keep its replacement state. When replacing a menu, check the instance again after deactivation so an old instance cannot install an orphaned menu.

Validation: the disconnect regressions failed before the initial fix. Reentrant teardown and duplicate input handling also reproduced failures, and removing the activation guard reproduced a rejected start() call. Two menu replacement regressions additionally failed when deactivation disconnected or reconnected the element. All 52 Chromium tests now pass, as do full ESLint, TypeScript, Rollup library and test builds. An external IPv4 Karma configuration avoided a local browser capture timeout; Firefox and WebKit were not run.

[Copilot]

🟡 Changes recommended

Disconnect cleanup remains unsafe during synchronous event callbacks.

3 open issues

• Guard activation when listener removes the element · New
• Prevent reentrant teardown during deactivation listeners · New
• Detach handlers before synchronous deactivation listeners run · New

What changed in this PR

Improves <text-expander> disconnect cleanup and preserves replacement state during reconnection.

Changes:

• Clear pending matches and deactivate open menus during teardown.
• Delete disconnected state before cleanup callbacks run.
• Add disconnect, reconnection, and delayed-provider regression tests.

File	Description
test/​text-expander-element-test.js	Adds lifecycle cleanup regression tests.
src/​text-expander-element.ts	Updates teardown and state-deletion order.

_{Review effort: Max}

[Copilot]

🟡 Changes recommended

Menu replacement can still resume activation on a destroyed instance after a deactivation listener disconnects the element.

1 open issue

• Abort menu replacement when deactivate disconnects the expander · New

3 resolved since last review

• Detach handlers before synchronous deactivation listeners run
• Prevent reentrant teardown during deactivation listeners
• Guard activation when listener removes the element

_{Review effort: Max}

[Copilot]

🔵 Needs a closer look

The public deactivation behavior and reentrant lifecycle changes warrant maintainer review, with browser validation limited to Chromium.

No open issues 🎉

1 resolved since last review

• Abort menu replacement when deactivate disconnects the expander

_{Review effort: Max}