Skip to content

fix(app): say who asked for a teammate's run and whose machine and key ran it - #638

Merged
iamnbutler merged 3 commits into
mainfrom
fix-who-ran
Oct 22, 2026
Merged

iamnbutler merged 3 commits into
mainfrom
fix-who-ran

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

A run a teammate asks for now says who asked and what ran it, on both sides.

  • The run card's byline credits the asker and names the machine and key: the owner reads asked by octocat · ran on your H72Q5YQ4CG with your key. The guest reads asked by you · ran on sam's H72Q5YQ4CG with their key. Hosted and cloud channels name their workspace and service instead.
  • Team pulse credits a run's end to ran.author, the person who asked, rather than the channel owner. A teammate's run in your own channel now shows under them.
  • When a teammate's run ends in your channel while you aren't watching it, the owner gets a notification (rivera used your agent, plus , and the run failed when it failed), or the window glows.
  • A guest's Agent access tooltip names the owner and machine (run commands as sam on H72Q5YQ4CG, with sam's model keys…) instead of "as you on this machine".

Fixes #601. Map: ^587, ^431, ^619.

Smoke test on an isolated host (own ACE_HOME, port 4731, --loopback --demo) with a synthetic teammate who really asked @ace, using a real Anthropic model:

  • Owner view: the card byline and Team pulse (octocat · Here / Finished in #w3chan) both showed the expected text.
  • Guest view (the channel's owner was changed to another login on disk): both cards showed the guest wording, and the tooltip showed the new copy.
  • Not tested: the owner's desktop notification. Headless Chromium has no desktop bridge.

Built in Ace

Made from Claude Code (a fix-train worker), not in Ace, because it was run headless as a parallel agent with its own isolated host. Gap tracked in the dogfooding meta issue, #5.

…y ran it

Why: apps/app/src/pulse.ts#function pulse | a run end belongs to ran.author, not the channel owner; guests run agents in others' channels
@iamnbutler
iamnbutler merged commit d4d184f into main Oct 22, 2026
1 check passed
@iamnbutler
iamnbutler deleted the fix-who-ran branch October 22, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A teammate's agent run doesn't say who started it or whose Mac and key ran it

1 participant