Repository navigation
fix(app): say who asked for a teammate's run and whose machine and key ran it - #638
Merged
Merged
Conversation
…y ran it Why: apps/app/src/pulse.ts#function pulse | a run end belongs to ran.author, not the channel owner; guests run agents in others' channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run a teammate asks for now says who asked and what ran it, on both sides.
asked by octocat · ran on your H72Q5YQ4CG with your key. The guest readsasked by you · ran on sam's H72Q5YQ4CG with their key. Hosted and cloud channels name their workspace and service instead.ran.author, the person who asked, rather than the channel owner. A teammate's run in your own channel now shows under them.rivera used your agent, plus, and the run failedwhen it failed), or the window glows.run commands as sam on H72Q5YQ4CG, with sam's model keys…) instead of "as you on this machine".Fixes #601. Map: ^587, ^431, ^619.
Smoke test on an isolated host (own ACE_HOME, port 4731,
--loopback --demo) with a synthetic teammate who really asked @ace, using a real Anthropic model:octocat · Here / Finished in #w3chan) both showed the expected text.Built in Ace
Made from Claude Code (a fix-train worker), not in Ace, because it was run headless as a parallel agent with its own isolated host. Gap tracked in the dogfooding meta issue, #5.