Repository navigation
fix: tell both people where an ask to join stands - #643
Merged
Merged
Conversation
The asker's Waiting… compared peers by object, so the list's 5 s refresh dropped it to a disabled Ask to join; it now says when the request lapses and toasts when they're let in. The owner gets a desktop notification for an ask that arrives while Ace isn't focused, the dialog says when it lapses, and Approve or Deny confirms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask to join now tells both people where the request stands: the owner sees it as it arrives, and the asker sees when it lapses and when they're let in (^120).
Asker (Team setup → Ask to join)
Waiting…stays until the ask ends. It compared peers by object, so the peer list's 5 s refresh turned it into a disabledAsk to joinwith nothing said.TEAM_ASK_EXPIRES).Owner
Smoke test
An isolated owner host (own ACE_HOME, config, keychain service, port 4955) shared on the tailnet listener, with its app in headless Chromium. A real peer ask came in through
GatewayClientoverws://<tailnet ip>:4955/ws:Not checked
Part of #632 (the quit-app case remains).
Built in Ace
No. This was made from Claude Code as a fix-train worker, using a headless Chromium and a Bun script as the asking peer. Ace has no way yet to run an agent-driven fix queue across several workers like this (#5).