Skip to content

Clean up callback flow for sign-in and verify flow. #427

Open

Description

@brnnmrls

Issue found in: #414 (comment)

The current sign-in and verify flow are brittle when processing the authorization response. The current flow will depend on an [authFlow wait] to ensure a token request is made before moving forward. Doing so makes the code harder to understand and easy to break. A way to improve this is by adding completion callbacks to ensure a tokenRequest is made before returning an instance of GIDAuthFlow.

Activity

  1. added
    bugSomething isn't working
    triageIssues that need to be triaged
    on May 21, 2024
  2. self-assigned this
    on May 21, 2024
  3. added
    enhancementNew feature or request
    and removed
    bugSomething isn't working
    triageIssues that need to be triaged
    on May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions