Repository navigation
Conversation
w-goog
force-pushed
the
codegen/ocmock-02-device-lacontext-seams
branch
from
October 21, 2026 22:03
eac9534 to
39a9801
Compare
…DMDMPasscodeCache
…tead of swizzling
w-goog
force-pushed
the
codegen/ocmock-02-device-lacontext-seams
branch
from
October 23, 2026 23:21
39a9801 to
c7207b1
Compare
mingyokim
approved these changes
Oct 28, 2026
Comment on lines
+25
to
+26
| #import "GoogleSignIn/Sources/GIDDevice/API/GIDDevice.h" | ||
| #import "GoogleSignIn/Sources/GIDEMMErrorHandler.h" |
There was a problem hiding this comment.
nit: Do these need to be imported or can we use forward declaration? i.e. @class GIDEMMErrorHandler and @protocol GIDDevice
|
|
||
| #import <Foundation/Foundation.h> | ||
|
|
||
| #import "GoogleSignIn/Sources/GIDLocalAuthentication/API/GIDLocalAuthenticationContext.h" |
There was a problem hiding this comment.
nit: Can we use forward declaration here?
There was a problem hiding this comment.
Is it okay for Fake files to live in Sources/**/Fake/*? Ideally these Fake files are not included in production targets and only included in test targets - please let me know if that is already the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the OCMock removal stack, on top of #658. This one removes the
UIDevice.systemNameandLAContextswizzles (and the MDM test's iOS 9 guards).GIDEMMSupportgets the device dep it needs. The class methods stay and delegate.GIDMDMPasscodeCachegetsLAContextthrough the initializer (yay for DI).UIDeviceandLAContexteach get a protocol + a fake for the tests to use.