Repository navigation
chore(audit): delete orphaned apps/web components and hooks - #2559
Merged
Merged
Conversation
Remove components, unused ui primitives, and useRealtimeVoice that have no production importers. Keep lib/preferences.ts because the preferences API route still imports it. Co-authored-by: KK <kk-agent@users.noreply.github.com>
Contributor
|
Please add a See governance: #898 |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
🔍 PR Validation |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Related: #2328
Outcome
Orphaned
apps/webcomponents, unusedui/primitives, anduseRealtimeVoiceare removed. Production importers were re-checked withrgon currentmainbefore deletion.Findings
Done:
components/AgentFlowVisualizer.tsx— no production importercomponents/ConsensusIndicator.tsx— no production importercomponents/OrchestratorRail.tsx(re-export) andcomponents/AnalysisPanel.tsx(imported only by that re-export)components/PipelineProgress.tsx— no production importercomponents/ResultsViewer.tsx— no production importercomponents/TracePanel.tsx— no production importercomponents/video-generator.tsxandsrc/lib/__tests__/video-generator-accessibility.test.tscomponents/billing/BillingStatusBanner.tsx— no production importercomponents/PreferencesPanel.tsx— no production importercomponents/ui/index.ts(barrel, zero importers) and unusedui/Badge.tsx,ui/Card.tsx,ui/Input.tsx,ui/SuggestedPrompts.tsx,ui/tabs.tsx,ui/textarea.tsx,ui/resizable.tsx,ui/resizable.test.tsx. KeptButton,alert,empty,field,label,separator.hooks/use-realtime-voice.tsandhooks/__tests__/use-realtime-voice.test.ts(only the test imported the hook)Skipped:
apps/web/src/lib/preferences.ts—PreferencesPanelis not its sole importer.apps/web/src/app/api/v1/preferences/route.tsalso imports it. API routes were left in place.Scope
/api/video/generate,/api/realtime/session,/api/v1/preferences),StudioIdeChat.tsx,StudioIdeShell.tsx,Nav.tsx,StudioIdeOutput.tsx,OneLoopStudio.tsx.Risk
rgon*.{ts,tsx,js,jsx}found no remaining production imports.Verification
Head
d8f89e2dc.npm ci --legacy-peer-deps— passednpm run lint— passednpm run build:web— passednpm --workspace=apps/web test— 1521 passed, 28 skipped, 2 failed insrc/lib/__tests__/home-sell-surface.test.ts. Same failure is already onmain(cd7e1998f, Actions run 41659258955, jobtest-frontend). The assertion looks for copy this deletion does not touch.Closing keyword check
Closing keyword to open issuefailed: https://github.com/groupthinking/EventRelay/actions/runs/41670373192/job/126036822988Production evidence
Not applicable. Deleted files had no production importers. No route or runtime behavior change.
Closes #2578