Skip to content

Node fetch ignore HTTP_PROXY settings. #145

Open

Description

@runningrunning

The commit is dda5ccd
It's mentioned in nodejs/node#42814 and nodejs/node#43187.

Activity

  1. changed the title [-]https://github.com/http-tests/cache-tests/commit/dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings.[/-] [+]dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings.[/+] on Feb 3, 2025
  2. changed the title [-]dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings.[/-] [+]Node `fetch` ignore HTTP_PROXY settings.[/+] on Feb 3, 2025
  3. mnot commented on Feb 3, 2025

    @mnot
    Collaborator

    Do you need to test a forward proxy? If not I'm inclined to just remove it from the docs for now.

  4. runningrunning commented on Feb 3, 2025

    @runningrunning
    Author

    Well, I can workaround by manually revert this commit.

    TBH, this repo help me a lot while developping the forward proxy, even from complementary purpose, I would suggest to at least mentioned it can be fixed or hotpatched through these two links in nodejs repo.

    And I don't think it's only useful for forward proxy, it maybe needed to bypass network limitation. Or how does the nginx been tested in the benchmark?

  5. runningrunning commented on Feb 3, 2025

    @runningrunning
    Author

    Since it's an issue in node already, maybe the doc can be just marked as a dependency. Or mentioned if it's needed, just manually revert this commit and wait until it's fixed on upstream.

  6. lifeisfoo commented on Mar 8, 2025

    @lifeisfoo

    Node.js HTTP_PROXY support is coming, see nodejs/node#57165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions