Repository navigation
chore(beacon): unschedule Hoodi Glamsterdam - #686
Conversation
eth-clients/hoodi#33 calls off the Gloas activation planned for epoch 132352 (2026-10-26 17:42:48 UTC): GLOAS_FORK_EPOCH goes back to far future and the Gloas-epoch GAS_LIMIT_SCHEDULE entry is removed. The built-in Hoodi config is eth-clients' file byte for byte, so it follows. A gloas build still carrying the old schedule would fork off Hoodi at that epoch. Its existing directories resume on the new file, since both the old and the new Gloas epoch are ahead of anything processed, which first_config_difference accepts since #677.
🤖 Kimi Code ReviewI'll review this PR diff focusing on the configuration changes for the Hoodi testnet. SummaryThis PR makes two changes to
Review Findings1. Critical:
|
| Priority | Action |
|---|---|
| High | Verify GLOAS_FORK_EPOCH: u64::MAX matches official Hoodi config at github.com/eth-clients/hoodi |
| High | Audit codebase for GAS_LIMIT_SCHEDULE references to ensure config parsing doesn't break |
| Medium | Confirm GLOAS naming is intentional vs. spec-standard naming |
Code Quality Assessment
The diff itself is clean and minimal. If the values are correct per spec, no code changes are needed. The removal of non-standard config fields is generally positive for maintainability.
No security vulnerabilities or memory safety issues in this config-only change, assuming values are spec-correct.
Automated review by Kimi (Moonshot AI) · kimi-k2.6 · custom prompt
🤖 Claude Code ReviewReview of PR 686: unschedule Hoodi GlamsterdamThe change is small and correct. It only touches
Before merge
Looks good to merge once upstream is final. Automated review by Claude (Anthropic) · sonnet · custom prompt |
🤖 Codex Code ReviewLooks good overall; this is a config-only PR and I don’t see a correctness, security, or performance regression for the current
Small maintainability note:
No requested changes from me. Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
🗒️ Description / Motivation
Hoodi's Glamsterdam fork is unscheduled: eth-clients/hoodi#33 calls off the Gloas activation planned for epoch 132352 (2026-10-26 17:42:48 UTC), which #677 picked up. Our built-in Hoodi config is eth-clients' file byte for byte, so it follows.
What Changed
bin/ethlambda/assets/hoodi/config.yamlis copied again frometh-clients/hoodiat987ca9a(#33's head):GLOAS_FORK_EPOCH13235218446744073709551615(far future)GAS_LIMIT_SCHEDULE132352GLOAS_FORK_VERSIONand the Gloas preset/timing keys stay, since upstream keeps them so the fork can be rescheduled with one epoch change.bootstrap_nodes.yamlalready matches upstream.Correctness / Behavior Guarantees
mainGAS_LIMIT_SCHEDULEdrops out of the ignored-keys warningfirst_config_differenceaccepts since #677Note
eth-clients/hoodi#33 is still open at the time of writing. If its final version differs, this file should be re-copied before merging.
Tests Added / Run
No new tests: nothing pins Hoodi's Gloas epoch.
Related Issues / PRs
✅ Verification Checklist
make fmt— n/a, no Rust changesmake lint(clippy with-D warnings) — n/a, no Rust changesmake test(test-consensusplustest-node, atrelease-fast) — rancargo test -p ethlambda --binsonly, the crate embedding the file