Repository navigation
Conversation
bjester
force-pushed
the
sandboxing-defense
branch
2 times, most recently
from
November 2, 2026 18:09
e660f7f to
de4c5fc
Compare
_get_client_ip_for_server opens a UDP socket to learn which local address routes to the server. AppArmor or a sandbox can refuse to create that socket, which raised outside the existing try block. It now logs a warning and returns 127.0.0.1, as it already did when the connect failed. The bare except is narrowed to OSError. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A MORANGO_NODE_ID set in the environment overrides the node ID, so test_consistent_0_5_instance_id got a different instance ID than the one it expects. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A sandbox can deny binding to port 0, which LiveServerTestCase uses by default and get_free_tcp_port used to find a free port. get_free_tcp_port moves to the test helpers and falls back to a fixed list of ports when port 0 is denied. A new FreePortLiveServerTestCase picks its port with it in setUpClass, so each class gets a port that is free when its server starts. The client test cases now extend it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
bjester
force-pushed
the
sandboxing-defense
branch
from
November 2, 2026 23:37
de4c5fc to
605afdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Short description
TODO
Reviewer guidance
If you PR has a significant size, give the reviewer some helpful remarks
Issues addressed
List the issues solved or partly solved by the PR
Documentation
If the PR has documentation, link the file here (either .rst in your repo or if built on Read The Docs)
AI usage