Repository navigation
Conversation
Treat bound UMD global exports as affecting global scope so incremental builds invalidate unchanged consumers after namespace or type changes. Add shared CLI and watch regression histories using the existing test framework. Baselines remain to be generated: offline framework execution is blocked by uncached test dependencies.
Dunqing
marked this pull request as ready for review
October 26, 2026 06:23
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
|
||
| import "testing" | ||
|
|
||
| func TestTscUMD(t *testing.T) { |
There was a problem hiding this comment.
This should just be in an existing tsc test. We have places for these that are not new files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #64967.
UMD declarations with
export as namespaceare incorrectly classified as not affecting global scope, allowing incremental builds to reuse stale diagnostics for unchanged consumers.Check
GlobalExportsafter binding so the existing global invalidation logic handles namespace, type, and file changes. Add CLI and watch regression histories that compare incremental results with fresh builds.The independent CLI reproduction passes all 11 stages with the fix (four mismatches without it). The new framework tests and baselines remain pending because test dependencies are unavailable offline. Full test, lint, and repository format checks have not been run.
AI assistance: The implementation and tests were authored with AI assistance.