Repository navigation
[docs] Document Go options merging and numeric unions - #1968
Draft
aspire-repo-bot[bot] wants to merge 1 commit into
Draft
aspire-repo-bot[bot] wants to merge 1 commit into
aspire-repo-bot[bot] wants to merge 1 commit into
Conversation
Merged
4 of 14 tasks
Contributor
Author
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents changes from microsoft/aspire#21188
Author:
@sebastienrosreviewed; PR author mention: see source PR.Targeting
release/17.0based on the source PR milestone17.0(target_resolution:exact_match).Why
The source PR fixes a Go AppHost panic when merging options structs that hold callbacks, and makes number unions accept any Go numeric type. These are user-visible Go SDK behaviors (signals:
polyglot_code_generator_changed,pr_body_has_cli_flag_mention).Changes
src/frontend/src/content/docs/app-host/go-apphost-conventions.mdx— explains how multiple options structs merge and that numeric parameters in unions accept any Go numeric type.