Repository navigation
Persist final container network disconnect in status - #323
Open
Tom Longhurst (thomhurst) wants to merge 1 commit into
Open
Tom Longhurst (thomhurst) wants to merge 1 commit into
Tom Longhurst (thomhurst) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the final managed network disconnects, the container controller reports
statusChangedbut its state initializers only assignStatus.Networksfor nonempty results. The old network remains in status, so each reconciliation detects the same disconnect, inspects the container again, and writes status again.Assign the network result when network status actually changed, including an empty result. Apply the correction to the running/paused, exited, and failed-start callers. Lookup failures still preserve the last known network status and request another reconciliation.
Regression coverage checks all four states: one old network becomes empty, the first pass reports a status update, and the next pass reports no change. It also checks lookup failures and exercises last-network removal and container stop through the standard integration API server.
Validation:
TestValidateRestrictedDirectoryAllowsInheritedReadOnlyAccess, reproduced separately with unchanged filesystem code.golangci-lintpasses on Windows, Darwin, and Linux.The same defect affects DCP 0.26.6. The release/0.26 backport for paired consumers is #324.