Repository navigation
Improve COM inproc initialization - #6607
Merged
JohnMcPMS merged 3 commits intoOct 22, 2026
Merged
Conversation
Flor Chacón (florelis)
approved these changes
Oct 22, 2026
ranm-msft
approved these changes
Oct 22, 2026
ranm-msft
left a comment
Contributor
There was a problem hiding this comment.
Initialization now stays outside DllMain and remains once-only across both activation exports. The blocked-log-path unit and activation tests cover the nonfatal logging path, and the current builds and tests are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Move initialization out of DllMain for the inproc module; the initialization is doing too much to be done there.
Make file logging best effort; if file logging is blocked for some reason, we won't get any logs and nothing will work. Let callers attempt to operate, although if the temp location is blocked for some reason we will likely fail later.
🔍 Validation
Added tests for scenario where logging location is blocked.
Microsoft Reviewers: Open in CodeFlow