Repository navigation
fix: Remove auto increment migration on share_external - #65669
Open
SystemKeeper wants to merge 1 commit into
Open
SystemKeeper wants to merge 1 commit into
SystemKeeper wants to merge 1 commit into
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Antreesy
approved these changes
Oct 19, 2026
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Otherwise great and minimalistic solution! Thanks =)
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { | ||
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); | ||
| $schema->dropAutoincrementColumn('share_external', 'id'); |
Contributor
There was a problem hiding this comment.
I wonder if it make sense to add a guard here:
Suggested change
| $schema->dropAutoincrementColumn('share_external', 'id'); | |
| $table = $schema->getTable('share_external'); | |
| if (!$table->getColumn('id')->getAutoincrement()) { | |
| return null; | |
| } | |
| $schema->dropAutoincrementColumn('share_external', 'id'); |
Works on MariaDB locally, but assisted review shows it can yield an error on Oracle DB, if you try drop a column that doesn't match condition
6 of 9 tasks
CarlSchwan
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Returning
nullwill stop the migration, so on existing installations the migration never ran.Checklist
3. to review, feature component)stable32)AI (if applicable)