Skip to content

Update bwameth to 0.2.10 - #13486

Open
heuermh wants to merge 5 commits into
nf-core:masterfrom
heuermh:bwameth-0.2.10
Open

heuermh wants to merge 5 commits into
nf-core:masterfrom
heuermh:bwameth-0.2.10

Conversation

@heuermh

@heuermh heuermh commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@github-actions

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mashehu
mashehu disabled auto-merge October 29, 2026 20:26
@mashehu
mashehu enabled auto-merge October 29, 2026 20:26

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing the cond-lock files?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I did was run nf-core modules bump bwameth and then test with nf-test and update snapshots. I'm not even sure what cond-lock files are for, it's hard to keep up 😅

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using the latest version of tools (4.2.1)? the conda lock files will allow us to finally have reproducible conda builds

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I was on 4.2.0, sorry

@heuermh

heuermh commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

@mashehu Thank you for your help! Is there anything left to do here? If I put the state of the conda files in peril, I can start again from scratch with tools version 4.2.1 and create a new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants