Skip to content

Support for Node 12/master #829

New issue
New issue
Closed
#831
Closed
Support for Node 12/master#829
#831

Description

@mcollina
mcollina
opened on Dec 15, 2018

It seems this module has not been updated to support Node 11, and I've a fear it might not be working on Node 12/master. It's not even in CIGTM.

Because of the critical importance for older packages, can somebody expert on this check it out?

Activity

  1. Flarna commented on Dec 16, 2018

    @Flarna
    Flarna
    on Dec 16, 2018
    Member

    Regarding Node 11 NAN works fine. I created #830 to update readme and CI matrix.
    But for Node 12 there is something to do as APIs have been removed/have been deprecated.

  2. kkoopa commented on Dec 16, 2018

    @kkoopa
    kkoopa
    on Dec 16, 2018
    Collaborator

    I just published a long overdue update, but it does not address Node 12.

  3. reconbot commented on Dec 17, 2018

    @reconbot
    reconbot
    on Dec 17, 2018

    @mcollina is nan not important for newer packages too?

  4. mcollina commented on Dec 17, 2018

    @mcollina
    mcollina
    on Dec 17, 2018
    SponsorMemberAuthor

    I think nan is important for existing packages. We can’t expect packages to migrate to napi in a short timeframe.

  5. kkoopa
    closed this as completedin #831on Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions