std::exception not caught #1225

Activity

1. mhdawson commented on Oct 28, 2022

   

   mhdawson

   on Oct 28, 2022

   Member

   More actions

   Do you have a simple recreate that we can turn into a test ?
2. NickNaso commented on Nov 3, 2022

   

   NickNaso

   on Nov 3, 2022

   Member

   More actions

   Hi @froody,

   you're right only the exception of type Napi::Errorare autimatically converted to a JavaScript exception.

   #include <napi.h>
   
   
   Napi::Value MethodCppExcpetion(const Napi::CallbackInfo& info) {
     Napi::Env env = info.Env();
     throw std::invalid_argument("Cpp exception.");
     return env.Undefined();
   }
   
   Napi::Value MethodNapiExcpetion(const Napi::CallbackInfo& info) {
     Napi::Env env = info.Env();
     throw Napi::Error::New(env, "Napi exception");
     return env.Undefined();
   }
   
   Napi::Object Init(Napi::Env env, Napi::Object exports) {
     exports["MethodCppExcpetion"] = Napi::Function::New(env, MethodCppExcpetion);
     exports["MethodNapiExcpetion"] = Napi::Function::New(env, MethodNapiExcpetion);
     return exports;
   }
   
   NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)

   If you call MethodCppExcpetion from your JavaScript code:

   'use strict'
   
   const addon = require('bindings')('addon')
   
   addon.MethodCppExcpetion()

   you will get something like this:

   libc++abi: terminating with uncaught exception of type std::invalid_argument
   zsh: abort      node index.js
   

   If you call MethodNapiExcpetion from your JavaScript code:

   'use strict'
   
   const addon = require('bindings')('addon')
   
   console.log(addon.MethodNapiExcpetion())

   you will get something like this:

   addon.MethodNapiExcpetion()
         ^
   
   Error: Napi exception
       at Object.<anonymous> (/Users/nicoladelgobbo/Downloads/addon/index.js:6:7)
       at Module._compile (node:internal/modules/cjs/loader:1159:14)
       at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
       at Module.load (node:internal/modules/cjs/loader:1037:32)
       at Module._load (node:internal/modules/cjs/loader:878:12)
       at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)
       at node:internal/main/run_main_module:23:47
   
   Node.js v19.0.0
   

   We had some discusssion about this in the past in this issue #601. The proble is the we don't know what you want to do when a C++ exception will thrown and for now we leaved this respnsibility to the developer bucause we were unsure that trasform a Cpp exception could be the best option.

   At least the documentation should be changed, do you want to make a PR?
3. mhdawson commented on Nov 18, 2022

   

   mhdawson

   on Nov 18, 2022

   Member

   More actions

   Discussed in the Node-API team meeting today and @NickNaso is going to update the docs to make it clearer.
4. NickNaso commented on Jan 13, 2023

   

   NickNaso

   on Jan 13, 2023

   Member

   More actions

   I'm closing we updated the documentation through this PR #1241.
5. NickNaso

   closed this as completedon Jan 13, 2023