Skip to content

Port absl config to gyp #211

Closed
Closed
Port absl config to gyp#211

Description

@targos
targos
opened on Sep 21, 2021

https://github.com/nodejs/node-v8/actions/runs/1256415634

In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Activity

  1. targos
    changed the title [-]Port absl config[/-] [+]Port absl config to gyp[/+] on Sep 21, 2021

  2. targos commented on Sep 21, 2021

    @targos
    targos
    on Sep 21, 2021
    MemberAuthor

    This is an external dep to V8 that we'll have to pull.
    Main BUILD.gn: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+/refs/heads/main/BUILD.gn

    I probably won't have time to work on this in the near future.

  3. targos commented on Sep 21, 2021

    @targos
    targos
    on Sep 21, 2021
    MemberAuthor

    I disabled the canary update GitHub action. It won't work until this is done.

  4. richardlau commented on Sep 21, 2021

    @richardlau
    richardlau
    on Sep 21, 2021
    Member

    Is this likely to block V8 9.5 for Node.js 17?

  5. targos commented on Sep 22, 2021

    @targos
    targos
    on Sep 22, 2021
    MemberAuthor

    No, this is blocking V8 9.6

  6. richardlau commented on Sep 24, 2021

    @richardlau
    richardlau
    on Sep 24, 2021
    Member

    I've opened node-core-utils PR to add abseil to the fetched V8 dependencies on V8 updates: nodejs/node-core-utils#565

  7. richardlau commented on Sep 24, 2021

    @richardlau
    richardlau
    on Sep 24, 2021
    Member

    https://github.com/nodejs/node-v8/actions/runs/1256415634

    In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

    FWIW this particular use was reverted in v8/v8@d67f060

  8. targos commented on Sep 25, 2021

    @targos
    targos
    on Sep 25, 2021
    MemberAuthor

    https://github.com/nodejs/node-v8/actions/runs/1256415634

    In file included from ../deps/v8/src/base/platform/mutex.h:10,
                 from ../deps/v8/src/base/platform/condition-variable.h:10,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.h:13,
                 from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5:
../deps/v8/src/base/optional.h:8:10: fatal error: absl/types/optional.h: No such file or directory
    8 | #include "absl/types/optional.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

    FWIW this particular use was reverted in v8/v8@d67f060

    Right. It re-enabled the job as it seems V8 doesn't use absl anywhere after this revert.

  9. targos commented on Jul 18, 2022

    @targos
    targos
    on Jul 18, 2022
    MemberAuthor

    Closing as this didn't show up again after almost a year.

  10. targos
    closed this as completedon Jul 18, 2022

  11. targos commented on Nov 13, 2023

    @targos
    targos
    on Nov 13, 2023
    MemberAuthor

    It's back:

    In file included from ../../deps/v8/src/objects/source-text-module.h:11:
../../deps/v8/src/zone/zone-containers.h:20:10: fatal error: 'absl/container/flat_hash_map.h' file not found
#include "absl/container/flat_hash_map.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[1161/3998] CC obj/tools/icu/gen/icudata.icudt73_dat.o
ninja: build stopped: subcommand failed.
make: *** [node] Error 1
  12. targos
    reopened this on Nov 13, 2023

  13. targos commented on Nov 13, 2023

    @targos
    targos
    on Nov 13, 2023
    MemberAuthor

    v8/v8@fa7521e

  14. targos
    added 2 commits that reference this issue on Nov 13, 2023

    feat: add Abseil to V8 deps

    8126792

    feat: add Abseil to V8 deps (#751)

    5c1cb89

  15. 164 remaining items

  16. nodejs-github-bot
    added a commit that references this issue on Mar 23, 2024

    tools: roughly port v8_abseil to gyp

    1d797e4
  17. nodejs-github-bot
    added 2 commits that reference this issue on Mar 24, 2024

    tools: roughly port v8_abseil to gyp

    8e87c88

    tools: roughly port v8_abseil to gyp

    5bf1e26
  18. targos
    added a commit that references this issue on Mar 25, 2024

    tools: roughly port v8_abseil to gyp

    0f30b25
  19. nodejs-github-bot
    added a commit that references this issue on Mar 25, 2024

    tools: roughly port v8_abseil to gyp

    04f9fd7
  20. targos
    added a commit that references this issue on Mar 26, 2024

    tools: roughly port v8_abseil to gyp

    33c9137
  21. nodejs-github-bot
    added 3 commits that reference this issue on Mar 26, 2024

    tools: roughly port v8_abseil to gyp

    ec2e30b

    tools: roughly port v8_abseil to gyp

    e3a40bb

    tools: roughly port v8_abseil to gyp

    15e65d2
  22. targos
    added 2 commits that reference this issue on Mar 29, 2024

    tools: roughly port v8_abseil to gyp

    afb1c48

    tools: roughly port v8_abseil to gyp

    80e374c
  23. nodejs-github-bot
    added 2 commits that reference this issue on Mar 30, 2024

    tools: roughly port v8_abseil to gyp

    ff7e4d3

    tools: roughly port v8_abseil to gyp

    56820f2
  24. targos
    added a commit that references this issue on Mar 31, 2024

    tools: roughly port v8_abseil to gyp

    c22793d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions