Skip to content

Broken build on Windows #89

Closed
Closed
Broken build on Windows#89

Description

@targos
targos
opened on Nov 17, 2018

https://ci.nodejs.org/job/node-compile-windows/22413/label=win-vs2017/console

Error:

09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_size_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 c:\workspace\node-compile-windows\Release\node.exe : fatal error LNK1120: 2 unresolved externals [c:\workspace\node-compile-windows\node.vcxproj]

Activity

  1. refack commented on Nov 20, 2018

    @refack
    refack
    on Nov 20, 2018

    @targos do you know which change made this regression?

  2. targos commented on Nov 20, 2018

    @targos
    targos
    on Nov 20, 2018
    MemberAuthor

    @refack Probably this change: v8/v8@bd8ed720cfa
    Corresponding gypfile update: 0b2a344

  3. refack commented on Nov 20, 2018

    @refack
    refack
    on Nov 20, 2018

    Thanks. I think it's a GYP bug (it does not map .S files as proper files to compile).
    On it.

  4. bzoz commented on Nov 21, 2018

    @bzoz
    bzoz
    on Nov 21, 2018

    FWIW manually changing embedded.S file type fixes compilation:
    image

  5. bzoz commented on Nov 21, 2018

    @bzoz
    bzoz
    on Nov 21, 2018

    Got it working, a GYP issue:

    diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
index 8fe9e5af23..ba585b1bfc 100644
--- a/tools/gyp/pylib/gyp/generator/msvs.py
+++ b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2171,6 +2171,9 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
   elif ext == '.asm':
     group = 'masm'
     element = 'MASM'
+  elif ext == '.S':
+    group = 'masm'
+    element = 'MASM'
   elif ext == '.idl':
     group = 'midl'
     element = 'Midl'

  6. refack commented on Nov 21, 2018

    @refack
    refack
    on Nov 21, 2018

    Thanks @bzoz! that's the patch I came up with as well.

  7. bzoz
    added a commit that references this issue on Nov 21, 2018

    build, tools, win: add .S files support to GYP

    160d2d2

  8. bzoz commented on Nov 21, 2018

    @bzoz
    bzoz
    on Nov 21, 2018

    PR with fix: nodejs/node#24553

  9. targos
    added a commit that references this issue on Nov 21, 2018

    build, tools, win: add .S files support to GYP

    13fb495

  10. refack commented on Nov 21, 2018

    @refack
    refack
    on Nov 21, 2018

    So FTR windows-32 is a different error:

    08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): error C2440: '?': cannot convert from 'v8::internal::Code' to 'bool' (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]
08:44:22   c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): note: Ambiguous user-defined-conversion (compiling source file ..\src\snapshot\startup-deserializer.cc)
08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(281): error C2660: 'v8::internal::Assembler::set_target_address_at': function does not take 2 arguments (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]
  11. pull
    added a commit that references this issue on Nov 29, 2018

    build, tools, win: add .S files support to GYP

    9920dbc
  12. bzoz
    closed this as completedin 9920dbcon Nov 29, 2018
  13. targos
    added a commit that references this issue on Nov 29, 2018

    build, tools, win: add .S files support to GYP

    383d809

  14. vsemozhetbyt commented on Dec 1, 2018

    @vsemozhetbyt
    vsemozhetbyt
    on Dec 1, 2018

    Still no Windows binaries in the last build?
    https://nodejs.org/download/v8-canary/v12.0.0-v8-canary2018120142ec383074/

  15. targos commented on Dec 1, 2018

    @targos
    targos
    on Dec 1, 2018
    MemberAuthor

    @ryzokuken fixed the canary branch today. Should be fine in the next build

  16. 108 remaining items

  17. targos
    added a commit that references this issue on Mar 9, 2019

    deps: sync V8 gypfiles with 7.2

    7c00f08
  18. nodejs-ci
    added 2 commits that reference this issue on Mar 9, 2019

    deps: sync V8 gypfiles with 7.2

    418793f

    deps: sync V8 gypfiles with 7.2

    a8055b9
  19. cjihrig
    added a commit that references this issue on Mar 12, 2019

    deps: sync V8 gypfiles with 7.2

    b80a80e
  20. ryzokuken
    added a commit that references this issue on Mar 12, 2019

    deps: sync V8 gypfiles with 7.2

    a9d13f9
  21. targos
    added a commit that references this issue on Mar 12, 2019

    deps: sync V8 gypfiles with 7.2

    e590cfd
  22. nodejs-ci
    added 3 commits that reference this issue on Mar 12, 2019

    deps: sync V8 gypfiles with 7.2

    36df017

    deps: sync V8 gypfiles with 7.2

    8dcbad0

    deps: sync V8 gypfiles with 7.2

    ab3f888
  23. targos
    added a commit that references this issue on Mar 14, 2019

    deps: sync V8 gypfiles with 7.2

    d266e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions