Skip to content

10.7.0 doc mistake: new vm.Module #21904

Closed
Closed
10.7.0 doc mistake: new vm.Module#21904
Labels
docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.vmIssues and PRs related to the vm subsystem.

Description

@zombieyang
zombieyang
opened on Jul 20, 2018
  // Since module has no dependencies, the linker function will never be called.
  await module.link(() => {});
  module.initialize();
  await module.evaluate();

the method initialize does not exist. May be instantiate is correct.

Activity

  1. ChALkeR
    added
    docIssues and PRs related to Node.js documentation.
    on Jul 20, 2018
  2. devsnek
    added
    vmIssues and PRs related to the vm subsystem.
    on Jul 20, 2018

  3. devsnek commented on Jul 20, 2018

    @devsnek
    devsnek
    on Jul 20, 2018
    Member

    yeah, it should be module.instantiate();. if anyone wants to take this: https://github.com/nodejs/node/blob/master/doc/api/vm.md

  4. devsnek
    added
    good first issueIssues that are suitable for first-time contributors.
    on Jul 20, 2018

  5. sagirk commented on Jul 20, 2018

    @sagirk
    sagirk
    on Jul 20, 2018
    Contributor

    I'm taking this up.

  6. devsnek
    closed this as completedon Jul 20, 2018
  7. sagirk
    added a commit that references this issue on Jul 20, 2018

    doc: fix incorrect method invocation on vm.Module instance

    e85cc85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.vmIssues and PRs related to the vm subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions