Repository navigation
http{s}: fix connecting to localhost if URL is invalid - #2967
Closed
thefourtheye wants to merge 1 commit into
Closed
thefourtheye wants to merge 1 commit into
thefourtheye wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the URL passed to
http.requestis not properly parsable byurl.parse, wefall back to use
localhostand port 80. This creates confusing error messageslike in this question http://stackoverflow.com/q/32675907/1903116.
This patch throws an error message, if
url.parsefails to parse the URL.Previous Discussion: #2966