Repository navigation
[v22.x backport] module: link module with a module request record - #60000
Merged
Merged
Conversation
When a module is being statically linked with module requests, if two module requests with a same specifier but different attributes are resolved to two modules, the module requests should be linked to these two modules. PR-URL: nodejs#58886 Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule Refs: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#how-would-this-proposal-work-with-caching Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
|
Review requested:
|
Collaborator
Collaborator
richardlau
approved these changes
Oct 3, 2025
Contributor
|
Landed in 2237142 |
jantimon
added a commit
to jantimon/diffshub-for-github
that referenced
this pull request
Sep 18, 2026
GitHub's threads endpoint returns the comments but not what they are attached to. The line is only in the data the changes page embeds for its React app, so the content script reads that page: diffSummaries maps each file's lines to thread ids, and markers.threads holds the bodies. They render through the viewer's annotations, at the line and on the side they belong to. Comment bodies render as text rather than GitHub's HTML, so nothing from a pull request is put into the page as markup. Reading the threads runs once. It was keyed on the toast helper, which changes identity whenever a toast appears, so a failure fetched the page again and raised another toast until GitHub started refusing. Writes move to their own suite against an open pull request of ours: GitHub answers 404 to file_review on a merged one, which is what nodejs/node#60000 became. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a module is being statically linked with module requests, if two module requests with a same specifier but different attributes are resolved to two modules, the module requests should be linked to these two modules.
PR-URL: #58886
Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule
Refs: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#how-would-this-proposal-work-with-caching
Reviewed-By: Guy Bedford guybedford@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com