Repository navigation
bad relative links in blog feed #1817
Description
The blog feed (https://nodejs.org/en/feed/blog.xml) has a base "channel link" of https://nodejs.org/en/. Bare anchor links fail to work, e.g., #notable-changes, because they resolve relative to the channel link. For example: https://nodejs.org/en/#notable-changes.
I think the channel link needs to point to https://nodejs.org/<lang>/blog/.
Activity
boneskull commentedon Sep 20, 2018
I have spent a bit of time looking in to fixing this, and it's not clear where the fix needs to be:
channel > linkneed to change away from the site's root?xml:basesomewhere (e.g., onitem)?metalsmith-feed?But I have confirmed it's not a reader-specific bug, because I've reproduced the behavior on multiple readers.
fhemberger commentedon Nov 1, 2018
@boneskull Sorry it took a while to look into this.
site.urlshould behttps://nodejs.org/<lang>/blog/instead ofhttps://nodejs.org/<lang>/only for the RSS feeds. Unfortunately, we can't pass a custom value as parameter. This is actually an issue inmetalsmith-feed, maybe you can raise an issue there.See: https://github.com/hurrymaplelad/metalsmith-feed/blob/master/metalsmith_feed.js#L27
boneskull commentedon Nov 1, 2018
@fhemberger Is this worth bothering with? Wondering if we are hitching our wagon to Metalsmith for the foreseeable future, or whether a next-generation nodejs.org site would use different tech...
fhemberger commentedon Nov 1, 2018
I don't know. Might still be worth reporting, also for the sake of others. But I'll leave that up to you.
fhemberger commentedon Nov 22, 2018
@boneskull I'm closing this issue for now. Feel free to open one for
metalsmith-feed, we are happy to accept a PR once it's fixed.