Repository navigation
Read a full scan's vectors through one blob handle per chunk - #1
Merged
mceachen merged 1 commit intoOct 23, 2026
Merged
Conversation
…e per chunk A vec0 full scan read each row's vector through vec0_get_vector_data(), which looks up the row's chunk, opens the chunk's vectors blob, reads one vector and closes the blob again. A chunk's blob holds chunk_size vectors (3 MiB for 1024 float[768]), and each open seeks through its overflow pages to reach the row's offset, so the cost of one read grew with the chunk and dominated the scan: selecting every vector of a 10,000-row float[768] table took 844 ms, and computing vec_distance_cosine() against each 807 ms. The scan already visits rows in (chunk_id, chunk_offset) order. Its rowid statement now also returns each row's chunk_id and chunk_offset, and the cursor keeps one blob handle per vector column, moved to the next chunk with sqlite3_blob_reopen(). A write that replaces the chunk's row expires the handle; the read is then retried once on a newly opened handle, so the scan reads the chunk as it is now. Measured on the same table: selecting every vector takes 11 ms, and the vec_distance_cosine() scan 30 ms. tests/test-fullscan.py checks every row's vectors against point lookups across chunks with gaps and two vector columns, and reads a chunk rewritten in the middle of a scan; with the retry removed, that test fails on the first row read after the rewrite.
This was referenced Oct 22, 2026
Closed
mceachen
added a commit
that referenced
this pull request
Oct 23, 2026
…eading it #1 took each row's chunk position from the scan's sorted rowid statement, so a delete, insert or optimize on the same connection during the scan returned a zeroed vector, another row's vector, or an error. It also replaced the blob handle after any failed sqlite3_blob_reopen(), which dropped an interrupt, and did not recognize SQLITE_ABORT_ROLLBACK with extended result codes on.
Member
|
Merged, thanks. Review turned up three problems, fixed in f793711:
vlasky#17 and asg017#336 have the same code. |
MayCXC
added a commit
to MayCXC/sqlite-vec
that referenced
this pull request
Oct 23, 2026
A vec0 full scan read each row's vector through vec0_get_vector_data(), which looks up the row's chunk, opens the chunk's vectors blob, reads one vector and closes the blob again. A chunk's blob holds chunk_size vectors (3 MiB for 1024 float[768]), and the first read through a newly opened handle walks the blob's overflow pages up to the row's offset, so the opens dominated the scan. The scan already visits rows in (chunk_id, chunk_offset) order, and the cursor now keeps one blob handle per vector column, moved to the next chunk with sqlite3_blob_reopen(). Each row's chunk position is looked up when its vector is read: the scan's rowid statement sorts every row when the scan starts, so its positions would miss a delete, insert or optimize the same connection runs during the scan. A write that replaces the chunk's row expires the handle, and a rollback of a transaction that changed the schema invalidates it (SQLITE_ABORT, or SQLITE_ABORT_ROLLBACK with extended result codes on); the read is then retried once on a newly opened handle. Any other failure to move the handle, such as an interrupt, fails the read. The position lookup and that failure handling follow photostructure/sqlite-vec@f793711 by Matthew McEachen, which corrected this change after it merged there as photostructure#1. On a 10,000-row float[768] table (medians of 3 interleaved runs of 7 queries), selecting every vector takes 11.7 ms instead of 760.8 ms in a database file and 5.5 ms instead of 88.1 ms in memory, and vec_distance_cosine() against each 32.2 ms instead of 777.1 ms and 24.6 ms instead of 110.6 ms. tests/test-fullscan.py checks every row's vectors against point lookups across chunks with gaps and two vector columns, reads a chunk rewritten in the middle of a scan, fails on a row deleted during the scan instead of returning another row's vector, reads rows that optimize moves during the scan, and fails a scan cancelled while its handle moves to the next chunk; tests/test-unit.c scans across a rollback that changed the schema, with extended result codes off and on.
MayCXC
added a commit
to MayCXC/sqlite-vec
that referenced
this pull request
Oct 23, 2026
A vec0 full scan read each row's vector through vec0_get_vector_data(), which for a flat column looks up the row's chunk, opens the chunk's vectors blob, reads one vector and closes the blob again. A chunk's blob holds chunk_size vectors (3 MiB for 1024 float[768]), and the first read through a newly opened handle walks the blob's overflow pages up to the row's offset, so the opens dominated the scan. The scan already visits rows in (chunk_id, chunk_offset) order, and for a flat column the cursor now keeps one blob handle per vector column, moved to the next chunk with sqlite3_blob_reopen(). Each row's chunk position is looked up when its vector is read: the scan's rowid statement sorts every row when the scan starts, so its positions would miss a delete or insert the same connection runs during the scan. A write that replaces the chunk's row expires the handle, and a rollback of a transaction that changed the schema invalidates it (SQLITE_ABORT, or SQLITE_ABORT_ROLLBACK with extended result codes on); the read is then retried once on a newly opened handle. Any other failure to move the handle, such as an interrupt, fails the read. Rescore, IVF and DiskANN columns keep their vectors in tables of their own and are read row by row as before. The position lookup and that failure handling follow photostructure/sqlite-vec@f793711 by Matthew McEachen, which corrected this change after it merged there as photostructure#1. On a 10,000-row float[768] table (medians of 3 interleaved runs of 7 queries), selecting every vector takes 12.6 ms instead of 762.4 ms in a database file and 5.4 ms instead of 104.7 ms in memory, and vec_distance_cosine() against each 33.8 ms instead of 853.5 ms and 24.5 ms instead of 111.8 ms. tests/test-fullscan.py checks every row's vectors against point lookups across chunks with gaps and two vector columns, scans rescore and DiskANN columns beside a flat one, reads a chunk rewritten in the middle of a scan, fails on a row deleted during the scan instead of returning another row's vector, and fails a scan cancelled while its handle moves to the next chunk; tests/test-unit.c scans across a rollback that changed the schema, with extended result codes off and on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
vec0full scan reads each row's vector throughvec0_get_vector_data(), which looks up the row's chunk, opens the chunk's vectors blob, reads one vector and closes the blob again. A chunk's blob holdschunk_sizevectors (3 MiB for 1024float[768]), and eachsqlite3_blob_open()seeks through the blob's overflow pages to reach the row's offset, so one read costs more the larger the chunk, and the opens dominate the scan.On a 10,000-row
float[768]table in a database file:The scan already visits rows in
(chunk_id, chunk_offset)order. Its rowid statement now also returns each row'schunk_idandchunk_offset, and the cursor keeps one blob handle per vector column, moved to the next chunk withsqlite3_blob_reopen(). A write that replaces the chunk's row expires the handle (sqlite3_blob_read()answersSQLITE_ABORT); the read is then retried once on a newly opened handle, so the scan reads the chunk as it is now. With this change the two queries take 11 ms and 30 ms. Measured again on an idle machine (medians of 3 interleaved runs of 7 queries), they take 10.2 ms instead of 778.9 ms and 28.4 ms instead of 772.0 ms; in memory, 3.5 ms instead of 95.8 ms and 23.7 ms instead of 111.6 ms.tests/test-fullscan.pychecks every row's vectors against point lookups across chunks with deleted rows and two vector columns, and reads a chunk whose shadow row is rewritten in the middle of a scan. Both pass on main too, since the results are unchanged; with the retry removed, the second fails on the first row read after the rewrite. The full suite andmake test-asanpass. The commit adds a### Changedentry under[Unreleased]in CHANGELOG.md.The same change is open on vlasky/sqlite-vec as vlasky#17 and upstream as asg017#336, where it reads flat columns by chunk and leaves rescore, IVF and DiskANN columns, which keep their vectors in tables of their own, to be read row by row.