i18n(ja): fix the Aggregation and Column Pruning entries in terms-en-ja.md by yahonda · Pull Request #24438 · pingcap/docs

yahonda · 2026-10-13T05:25:58Z

What is changed, added, or deleted? (Required)

Fix two entries in resources/terms-en-ja.md:

Remove the Aggregation → 集計 entry.
Change Column Pruning → カラムの剪定 to 列プルーニング.

1. Remove the Aggregation entry

The right Japanese term for "aggregate/aggregation" depends on the context:

SQL aggregation (aggregate functions, GROUP BY, splitting or normalizing aggregates in the optimizer): 「集計」. This matches the Japanese docs of other databases (MySQL, SQL Server, and Snowflake use 集計関数; Oracle uses 集計ファンクション) and the existing TiDB Japanese docs.
Combining values into one array, JSON value, or geometry (for example, ARRAY_AGG, JSON_ARRAY_AGG, and ST_UNION_AGG): 「集約」 reads more naturally. 「JSON 配列へ集計する」 is unnatural Japanese.

The glossary is matched by case-insensitive substring, so this entry forces 「集計」 for every "aggregation", including the second case. It does not match "aggregate" or "aggregating" at all, so it does not keep the term consistent either. Removing it lets the translator choose from context.

This came up while reviewing the Japanese TiDB Cloud Lake docs, where 「集計」 and 「集約」 were mixed. The Japanese-side fixes will be filed separately against i18n-ja-release-8.5.

2. Use the katakana term for Column Pruning

「剪定」 means pruning plants. The body text of the Japanese TiDB docs already uses 「列プルーニング」 for column pruning in about 16 files, and the same glossary uses 「プルーニング」 for Dynamic pruning mode → 動的プルーニングモード. The existing Japanese docs that use 「剪定」 will be fixed separately against i18n-ja-release-8.5.

Note: I understand the policy of grouping related fixes into a few PRs. This PR groups the glossary fixes and is filed separately from the documentation fixes because it changes the translation glossary, not the documentation.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Related code change PR links (if applicable):
This PR is translated from:
Other reference link(s):

AI agent involvement

The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

Documentation
- Removed the “Aggregation” entry from the English-Japanese glossary.
- Updated the Japanese translation for “Column Pruning” from “カラムの剪定” to “列プルーニング”.

The entry forces one Japanese term for every "aggregation". The right term depends on context: one term for SQL aggregation, another for combining values into one array, JSON value, or geometry. Let the translator choose from context instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-13T05:26:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 5b8b2220-2a0b-48ad-a3d1-a22b6d559350

📥 Commits

Reviewing files that changed from the base of the PR and between e64cdb3 and 29c5e72.

📒 Files selected for processing: 1

resources/terms-en-ja.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The English-Japanese terms table removes the Aggregation → 集計 entry and changes the Column Pruning translation to 列プルーニング.

Changes: Glossary

Layer / File(s)	Summary
Update glossary entries `resources/terms-en-ja.md`	The table removes the `Aggregation` → `集計` row and changes the `Column Pruning` translation to `列プルーニング`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 29c5e

The glossary updates are limited to terminology changes; no actionable merge risk is established by the supplied context.

### Architecture Summary

Architecture risk: 🔵 Low · up to 29c5e

The change affects 1 system.

Changed systems: resources

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — resources (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in resources/terms-en-ja.md: The Aggregation → 集計 glossary row was removed.
observed — Modified behavior in resources/terms-en-ja.md: The Japanese translation for Column Pruning changed from カラムの剪定 to 列プルーニング.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely identifies the Japanese glossary fixes for the Aggregation and Column Pruning entries.
Description check		The description explains both glossary changes, their rationale, affected version, references, AI involvement, and applicable checklist items. It satisfies the required template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

The glossary translated "Column Pruning" with a word that means pruning plants. The Japanese TiDB docs use the katakana term for pruning in over 200 places, and the same glossary already uses it for "Dynamic pruning mode". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…erms-en-ja.md The body text of the Japanese TiDB docs already uses this term for column pruning in about 16 files, while the previous wording was used almost nowhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ti-chi-bot · 2026-10-16T09:23:26Z

[LGTM Timeline notifier]

Timeline:

2026-10-16 09:23:25.998542541 +0000 UTC m=+982215.745773380: ☑️ agreed by qiancai.

qiancai · 2026-10-16T09:23:40Z

/approve

ti-chi-bot · 2026-10-16T09:23:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2026

yahonda changed the title ~~i18n(ja): remove the Aggregation entry from terms-en-ja.md~~ i18n(ja): fix the Aggregation and Column Pruning entries in terms-en-ja.md Oct 14, 2026

yahonda mentioned this pull request Oct 14, 2026

i18n(ja): fix the column pruning term and optimizer rule names #24450

Merged

2 of 6 tasks

qiancai approved these changes Oct 16, 2026

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2026

qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2026

qiancai added the lgtm label Oct 16, 2026

ti-chi-bot Bot added the approved label Oct 16, 2026

ti-chi-bot Bot merged commit 64729fa into pingcap:master Oct 16, 2026
12 checks passed

yahonda deleted the remove-aggregation-ja-glossary-entry branch October 27, 2026 06:49

Navigation Menu

Repository navigation

i18n(ja): fix the Aggregation and Column Pruning entries in terms-en-ja.md - #24438

i18n(ja): fix the Aggregation and Column Pruning entries in terms-en-ja.md#24438
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
yahonda:remove-aggregation-ja-glossary-entry

yahonda commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

ti-chi-bot Bot commented Oct 16, 2026

Uh oh!

qiancai commented Oct 16, 2026

Uh oh!

ti-chi-bot Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yahonda commented Oct 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added, or deleted? (Required)

1. Remove the Aggregation entry

2. Use the katakana term for Column Pruning

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

AI agent involvement

Do your changes match any of the following descriptions?

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot Bot commented Oct 16, 2026

[LGTM Timeline notifier]

Uh oh!

qiancai commented Oct 16, 2026

Uh oh!

ti-chi-bot Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yahonda commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading